Re: RFS: daemonlogger
On Nov 14, 2007 8:06 AM, Chris Taylor <chris@code-monkeys.org> wrote:
> http://mentors.debian.net/debian/pool/main/d/daemonlogger/daemonlogger_1.0-1.dsc
That doesn't exist, here are some comments on the one that does:
Be sure to send the manual page upstream, and maybe the patch is also
appropriate.
Your patches should document why they were added to the package and
who wrote them.
You might want to add this to your ~/.quiltrc and regen the patches:
QUILT_REFRESH_ARGS="-p0 --no-timestamps --no-index"
These help in creating patch files that are more friendly to people
using interdiff on your diff.gz.
Lintian warnings when run with -I:
I: daemonlogger: hyphen-used-as-minus-sign
usr/share/man/man1/daemonlogger.1.gz:45
I: daemonlogger: hyphen-used-as-minus-sign
usr/share/man/man1/daemonlogger.1.gz:71
I: daemonlogger: hyphen-used-as-minus-sign
usr/share/man/man1/daemonlogger.1.gz:72
No need to install the NEWS file
The readme says: "This code is largely untested and probably
completely shoddy. YMMV.", is it really that untested? Presumably you
have tested it yourself and can patch that statement out?
The upstream source tarball contains ._COPYING and ._ChangeLog - I
assume these are from MacOS X, please ask upstream to remove them in
the next version (teaching them about "make dist" should be enough).
When building, I see this:
cc -DHAVE_CONFIG_H -I. -g -Wall -O2 -g -O0 -Wall -I/usr/include -c
daemonlogger.c
cc -g -Wall -O2 -g -O0 -Wall -I/usr/include -L/usr/lib -ldumbnet -o
daemonlogger daemonlogger.o -lpcap -ldumbnet
IIRC, debian policy is to use -O2 unless DEB_BUILD_OPTIONS=noopt is
set, please fix this to use only one -OX flag and check if noopt
works.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: