[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Sponsor found] Re: Bug#444509: grig: FTBFS: error: 'GtkTooltips' undeclared



I didn't read the discussion before, but I think I know what it's about
anyway, and I'd like to say something about it. :-)

On Tue, Oct 09, 2007 at 07:51:48PM +0200, Cyril Brulebois wrote:
> Bernd Zeimetz <bernd@bzed.de> (09/10/2007):
> > > I could have stripped these parts from the diff, but they would be
> > > added anyway,
> > 
> > no, you can just remove them in your clean target.
> 
> The point is exactly about adding them in the clean target, so that
> their being up-to-date is ensured during the build.

Running auto* will regenerate all files, so they will be up to date.
IMO (but others disagree), this is a good thing: everything should be
regenerated during a build.  This ensures that the included files are
indeed the source, and that users who change the source can use Debian's
build system to create packages with those changes included.

If you regenerate all generated files, it is safe to remove them in the
clean target.  That way, they will be skipped by the diff, which will
make the diff.gz much cleaner.

> > No need to change them at all - they're replaced at build time anyway.
> 
> Exactly because they are handled in the clean target, from which you
> propose to remove them. I might have troubles understanding your logic,
> if any.

If I understand correctly, you are installing new versions of config.*
in the clean target.  I suppose you do not run autoconf/automake,
because if you do, there is no need to do that.  The proposal was (it
seems to me) to change that.  If you do run automake and autoconf, the
new versions will be installed and you don't need to do anything.
Removing them in the clean target is just for making the diff.gz nice.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature


Reply to: