Re: RFS: gnome-color-chooser

[Patrick Schoenfeld <schoenfeld@in-medias-res.com>]

Jon Dowland schrieb:
> On Tue, Aug 28, 2007 at 07:19:22PM +0200, JackTheDipper wrote:
>> - dget http://mentors.debian.net/debian/pool/main/g/gnome-color-chooser/gnome-color-chooser_0.2.2-1.dsc
> 
> My initial test with debuild did not work:

I can confirm this. Your clean target is wrong. With this commented out
I have additional comments (note, that I am not a DD so this is just for
your help:

* You obviously miss all build-depends. Thats the reason why the
configure target fails with missing dependencies. You should try to
build your package in a e.g. pbuilder environment, so that you see what
dependencies your package has.

* debian/rules:
	- No need to keep template comments
	- What does this ifneq construct do in the config.status
          target? The build process should not make any assumptions on
          what might exist on the build system and should not use
          anything outside of the package (IMHO)
	- No need to keep commented debhelpers
	- dh_installman seems to be useless as you don't ship a manpage
	- there are plenty whitespaces at the end of lines, you should
          remove them
* debian/copyright:
	- I don't think that "JackTheDipper" is a valid legal person,
          therefore i consider debian/copyright to be invalid. It may
	  be better to contain real names.
	- a lot of empty spaces at the end of line
* debian/dirs (and dh_installdirs in rules) seems useless. Directories
will normally be created by the makefiles so this is double effort. But
I can't tell for sure as it does not build.
* debian/changelog:
	- Again: I don't think that "JackTheDipper" is a valid legal
	  person.
* debian/control:
	- Description is invalid. See 3.4 in the debian policy for 		
	  informations about this.

Regards,

Patrick