[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: audtty

On Wed, Aug 15, 2007 at 09:30:01AM +0200, Chris Taylor wrote......

> I fixed the spelling error, and cleaned up the rules file a bit.
> This rule tells CDBS that the makefile does not contain a check
> target, making sure that it does not attempt to call it.
> I uploaded the fixed packages to mentors.debian.net

A few more comments ...

The man page for audtty brings up what looks like an old man page
for xmms-curses. Not good.

Why do you still have this line in debian/changelog?

      * Updated package to upstream version 0.1.5a

Since this is initial release, it is not an updated package.

In debian/copyright:

    Upstream Author:  should be plural since there are 3

    In virtually every upstream file there is the copyright line:

        2003-2005 Knut Auvor Grythe

    Why did you put:

        2003-2004 Knut Auvor Grythe

    in debian/copyright? Note 2004 vs 2005.

I'm a bit picky, but I like to see all unnecessary whitespace and
extra double space lines removed from all files. Most of your
debian/ files still have extraneous whitespace in them.


Kevin Coyner  GnuPG key: 1024D/8CE11941

Reply to: