Re: ITR: gnome-phone-manager (updated package)
thanks for the review, I hope to find a sponsor because I think that
this package is useful and have waited for the dependencies with
Il giorno lun, 30/07/2007 alle 00.20 +0100, Neil Williams ha scritto:
> On Sun, 29 Jul 2007 23:04:17 +0100
> Neil Williams <firstname.lastname@example.org> wrote:
> OK, a quick review.
> debian/copyright seems very verbose - see #435070, I don't think all of
> those copyright lines are strictly necessary but that is not something
> you need to fix, just a curiosity.
fixed, I've removed the copyright information regarding the autotools
files. Every time I made a new package I'm in doubt for including or not
these informations. The debian/copyright is my nightmare... :)
> pbuilder build is fine. package contents appear fine. Ubuntu has this
> package already (and a few open bugs) but hasn't had an update recently
> - do you happen to know if your SVN code includes the patches that
> Ubuntu are currently using?
I've checked the ubuntu package, there are two patches, one for
the .desktop file, I've seen that in the SVN version it's changed and
fixed, the other one regards the configuration process. The released 0.8
version checks for openobex-config that it's deprecated from openobex
version 1.1 but this one issue also it's fixed in SVN version.
I've checked in the changelog of the svn and I've seed that many of the
bugs reported in launchpad appears fixed in this revision.
> The package also creates /usr/sbin because of a template debian/dirs
> file - that could be removed.
> One thing you should do, before the first upload, is create a
> debian/patches directory and add the CDBS simple patch system support
> to debian/rules.
> include /usr/share/cdbs/1/rules/simple-patchsys.mk
> This makes it a lot easier for others to test and implement patches
> to help you with bug reports. This is the kind of package that will
> attract quite a few bug reports and a lot of those will be specific to
> particular hardware that you simply cannot ever be able to test. Make
> sure you are ready for these kind of issues.
> There are some more checks to do - depending on how much time I can
> find in the next few days - but if anyone else is able to sponsor this
> one . . .
I've uploaded the new package to mentors: