-=| Erick Mattos, Sat, 23 Jun 2007 13:10:52 -0300 |=- > http://mentors.debian.net/debian/pool/main/c/codeblocks/codeblocks_1.0rc2~svn.20070620-1.dsc More comments, in several categories :) Nitpicks: * debian/codeblocks.desktop contains "GenericName[en_GR]=". Can you either fill it or remove it? * There are some commented-out lines in debian/rules' binary-arch target that are clearly never going to be needed. Please remove them. * usr/sbin is not used so no need to put it in debian/dirs. If make install creates its directories (as it should), there is no need for usr/bin too, rendering debian/dirs redundant. * The debian/menu file has no icon assitoated. Note that it needs an icon in XPM format so you may need to convert the .png to .xpm There is a great deal (>11M) of architecture-independent files installed in /usr/share. Please consider putting them in a separate, Arcitecture: all package (codeblocks-common) and make codeblocks depend on it. This will save space on archive mirrors. Shared libraries: I see you've added postinst/postrm scripts calling ldconfig. I guess this is because codeblocks installs libcodeblocks and libwxsmith in /usr/lib. Is this at all necessary? What is the purpose of these libraries? As far as I see, libcodeblocks is used bu /usr/bin/codeblocks and libwxsmith is unused. Are these libraries to be used by someone else than codeblocks? If they are for internal codeblocks (+ plugins) usage, they are better placed in /usr/lib/codeblocks and codeblocks linked with -rpath /usr/lib/codeblocks. Development files: Are the files in /usr/include/codevlocks needed for using Code::Blocks? If not, for example if they are needed only when developing C::B plugins, better place them in a separate (Architecture: all) package (codeblocks-plugin-dev/codeblocks-dev), possibly recommending it in codeblocks. There still are some lintian warnings that should be fixed. -- dam JabberID: dam@jabber.minus273.org
Attachment:
signature.asc
Description: PGP signature