[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: revoco

On Sat, 05 May 2007 20:52:33 +0300 Damyan Ivanov wrote:

> > http://mentors.debian.net/debian/pool/main/r/revoco/revoco_0.3-1.dsc
> SUID binary... this is scaring me. Is it really necessary?

Well, it is not necessary, but helps $USER to control the mouse.
You need to write some hex-values to /dev/usb/hiddevX to change the
settings of the mouse, and as this file is owned by root, you need
either to be root or to change the permissions... The possibilities to
work with are:
1. let the binary as it is, and tell $USER he has to use sudo or su
2. set the binary suid-root (the code looks OK for me - IANASE)
3. create some new group and let udev give this group write permission
to the 'file' -> IMHO overkill for such a small util

I could live with 1, but I think 2 is more userfriendly.

> You set CFLAGS in debian/rules and then patch Makefile to contain the
> same CFLAGS. I'd remove the CFLAGS from Makefile at all to leave only
> one place to change (if there is need).

Hm, yeah. The problem is, I need -DVERSION=foo in CFLAGS, which I think
I should not set from debian/rules... I've changed the patch now to

and call
from debian/rules - why the hell I need to set them before make?

I've uploaded to mentors, hope to get more comments ;)


   ^^^    | Evgeni -SargentD- Golov (sargentd@die-welt.net)
 d(O_o)b  | GPG/PGP-Key-ID: 0xAC15B50C
  >-|-<   | 0C04 F872 0963 ADC9 AA83 882B 24A0 1418 AC15 B50C
   / \    | http://www.die-welt.net - sargentd@jabber.die-welt.net

Michelle: Alle meine INCLUDERC's zusammengerechnet haben über 38000
Zeilen... Thorsten: Michelle, Du bist die coolste von allen! Darf ich
Dein Freund sein? (Thorsten Haude - debian-user-german)

Attachment: pgp9rB0GfkOEk.pgp
Description: PGP signature

Reply to: