[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: nautilus-image-converter



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

(changing subject and cc'ing to Debian Mentors <debian-mentors@lists.debian.org>)

Bart Martens ha scritto:
> Hi David,

Hi Bart,

> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=nautilus-image-converter
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374061
> 
> I see that these two files are not identical:
> http://www.bitron.ch/downloads/nautilus-image-converter-0.0.9.tar.gz
> http://mentors.debian.net/debian/pool/main/n/nautilus-image-converter/nautilus-image-converter_0.0.9.orig.tar.gz
> 
> md5sum nautilus-image-converter-0.0.9.tar.gz
> 135f0db76acb9de21b6a0ab96be614f9  nautilus-image-converter-0.0.9.tar.gz
> md5sum nautilus-image-converter_0.0.9.orig.tar.gz
> 49f0034531dba13bbdcb5bb23e5bb2f8  nautilus-image-converter_0.0.9.orig.tar.gz

They are indeed.
The md5sum changes because the original package provides config.sub and
config.guess, which are autogenerated by autotools and, therefore, shouldn't be
shipped with the upstream package at all.
When I build my .deb, the "clean" rule of debian/rules just deletes them, since
they're automatically generated.
I think this is a minor issue: should I contact the upstream author to remove
those files, or should I leave it the way it is? Debian Policy states (I don't
exactly remember where) that if the changes are of minor importance (like this
one), it is ok to use the "modified" version.

> I have also briefly compared your package with the package in Ubuntu.
> http://packages.ubuntu.com/nautilus-image-converter
> 
> Are you sure that the Build-Depends of your package is complete? You
> might want to use "pbuilder" to test that.  Is it OK that your package
> does not Depend on imagemagick? You might want to try using your package
> in a clean "chroot" to test that. Any other things that might be better
> in the Ubuntu package?

I've added imagemagick and nautilus: they were the missing ones.
About pbuilder: I can't create a pbuilder chroot. Here's the error it gives:

E: Couldn't install system due to errors!

The only noticeable thing is:

W: resolver (libdevmapper1.02): package doesn't exist

I've googled, but haven't found anything. I could create a chroot on my own, but
I'd like to use pbuilder. Do you have any idea on that?

> Note that your package is already very good, and on some points better
> than the package in Ubuntu.

Thank you.

> Regards,
> Bart Martens

Cheers,
David

- --
 . ''`.  Debian packager! | http://snipurl.com/gofoxygo/
 : :'  :   User #334216   |  http://www.hanskalabs.net/
 `. `'`   GPG: 1392B174   | http://www.debianizzati.org/
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGO1py5qqQFxOSsXQRAgXvAJ41HsXfYZ6rNvFxYOydGFRLn14NcQCgjtM0
pPmht8/rIm4TML/w86tmWs8=
=CmWu
-----END PGP SIGNATURE-----



Reply to: