[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: QGFE QT Gnuplot Front End

On Mon, 30 Apr 2007 10:00:40 +0200, Giorgio Pioda wrote:

> Download: http://web.ticino.com/gfwp/debian/qgfe-1.0/

I'm not a DD, but here go some short remarks on your package:

* debian/README.Debian is an empty template and can possibly be
* All the debian/foo.ex files seem to be unused templates; either 
  rename them (from foo.ex to foo) and adapt them or remove them. 
  menu would probably be the only useful one. Oh, and manpage.1.ex 
  -> qgfe.1
* The debian/changelog is still the template, you should close a real ITP
* debian/copyright still has a note at the bottom.
* debian/dirs is probably useless.
* debian/rules could use some cleanup; at least check that you have
  the correct dh_* helpers de-/activated.
* And: the package doesn't compile in a pbuilder chroot:

    # Add here commands to compile the package.
    #cd ..
    #qmake -unix PREFIX=/usr qgfe.pro
    make[1]: Entering directory `/tmp/buildd/qgfe-1.0'
    g++ -c -pipe -Wall -W -O2 -D_REENTRANT  -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_SHARED -DQT_TABLET_SUPPORT -I/usr/share/qt3/mkspecs/default -I. -I/usr/include/qt3 -I.ui/ -I.moc/ -o .obj/barOp.o barOp.cpp
    Assembler messages:
    Fatal error: can't create .obj/barOp.o: No such file or directory
    make[1]: *** [.obj/barOp.o] Error 2
    make[1]: Leaving directory `/tmp/buildd/qgfe-1.0'
    make: *** [build-stamp] Error 2
    pbuilder: Failed autobuilding of package

  A simple call of `qmake' before $(MAKE) in debian/rules fixes this
  problem. (BTW: Why do you ship a Makefile? It's not in the
  .orig.tar.gz as it's recreated by qmake).
  Hm, that's not enough:

    # Add here commands to install the package into debian/qgfe.
    /usr/bin/make DESTDIR=/tmp/buildd/qgfe-1.0/debian/qgfe install
    make[1]: Entering directory `/tmp/buildd/qgfe-1.0'
    cp -f "qgfe" "/usr/bin/qgfe"
    cp: cannot create regular file `/usr/bin/qgfe': Permission denied
    make[1]: [install_target] Error 1 (ignored)
    strip "/usr/bin/qgfe"
    strip: '/usr/bin/qgfe': No such file
    make[1]: [install_target] Error 1 (ignored)
    mkdir: cannot create directory `/usr/share/qgfe': Permission denied
    make[1]: *** [install_utilities] Error 1
    make[1]: Leaving directory `/tmp/buildd/qgfe-1.0'
    make: *** [install] Error 2
    pbuilder: Failed autobuilding of package
  We need to do something about the directories:
  qmake -unix PREFIX=$(CURDIR)/debian/qgfe/usr qgfe.pro
  But then several files end up in /usr/share/qgfe/ which is wrong
  too. Probably it's easier to do the install "by hand", i.e. with
  dh_install and a debian/install file.

* In debian/rule's clean target you could use "distclean" instead of
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  debian: the universal operating system - http://www.debian.org/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-    NP: Michael Franti & Spearhead: Thank You

Attachment: signature.asc
Description: Digital signature

Reply to: