Re: RFS: smc

[Oleksandr Moskalenko <malex@debian.org>]

* Muammar Wadih El Khatib Rodriguez <muammarelkhatib@gmail.com> [2007-04-22 14:14:14 -0400]:

> Dear mentors,
> 
> I am looking for a sponsor for my package "smc".
> 
> * Package name    : smc
>  Version         : 0.99.6-1
>  Upstream Author : Florian Richter <fluxey@gmail.com>
> * URL             : http://www.secretmaryo.org
> * License         : GPL
>  Section         : games
> 
> It builds these binary packages:
> smc        - a Jump and Run game like Super Mario World written in C++
> smc-data   - levels and music for smc
> 
> The package is lintian clean.
> 
> The upload would fix these bugs: 405441
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/smc
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/smc/smc_0.99.6-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Regards
> 
> -- 
> Muammar El Khatib.
> Linux user: 403107.
> Key fingerprint = 90B8 BFC4 4A75 B881 39A3  1440 30EB 403B 1270 29F1
> http://muammarelkhatib.net | http://www.teorex.org


Hello Muammar,

First, you've done a pretty good job on packaging this nice little game.
Having said that, there are some things I believe you should address.

* The sound does not work on a run of the mill alsa system I have.

Warning : Could not init 16-bit Audio
- Reason : No available audio device
Warning : Could not init 16-bit Audio
- Reason : No available audio device
Last known Error : No available audio device

This really shouldn't happen. Please look into this.


* You should have something like "On Debian systems, the complete text of the
GNU General Public | License, version 2, can be found in
/usr/share/common-licenses/GPL-2." right below the license header in the
debian/copyright and then just mention that your packaging is licensed under
GPL at the end.

* Is there a good reason to include
docs/history.html
docs/moves.txt
docs/readme-linux.txt
docs/SMC.txt
docs/todo-code.txt
docs/todo-sounds.txt
docs/todo.txt

I don't see what users of your package would find useful in those.
history.html could be repackaged as the upstream changelog I suppose if you'd
like to do that.

* I personally think you should distribute the menu smc.xpm icon in the "smc"
package instead of the smc-data. This will also allow you to avoid using a
lintian override.

* You have debian/README.source, but you don't install it into the /usr/share/doc/.

* And now the main point for the NEW queue - there are several licenses in
docs/licenses. Some of the look like the licenses for the software smc links
against that you don't distribute in your orig.tar.gz. I think you should
remove erroneous licenses from the tarball since you are already repackaging
it to include the data/music files, so you can do that easily. Only leave
those licenses that correspond to the code shipped in your source package. For
that code you must have a corresponding entry in the debian/copyright files.
Please do this and double-check all code in the tarball for the licensing.

After the above is addressed I'd be happy to upload the package for you. It
doesn't mean that ftpmasters won't find something else to shoot the package
down for - this is what I personally found.

Regards,

Alex.