[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: liblinux-kernelsort-perl | Simple sorting library for kernel version strings



Maximilian Wilhelm wrote:
> Package: deb http://debian.rfc2324.org/debian unstable liblinux-kernelsort-perl

Please post at least the URI to the *.dsc file, I don't want to search
for a package to find the sources.

> Anyone who wantŽs to sponsor it?

I can do that, but there needs to be some things fixed first:

  * Remove the useless empty line at the end of changelog.

  * Merge -1 and -2, so that -1 will be the first revision uploaded to
    debian.

  * The line with the Homepage in control should have two leading
    spaces.

  * use the more common way to write debian/copyright, add the GPL blurb
    look at libextractor for an example.

  * don't use more than one empty line in rules as seperator.

  * remove the commented stuff which is not used.

  * the CFLAGS stuff is useless, same with the shlib stuff

  * remove the configure: target, it's useless

  * hint: if you include dpatch.make, you can write much simpler rules,
    look at e.g. lwp for an example.

  * remote the commended dh_* calls, as well as the ones which are not
    required for your package, e.g. dh_installexamples and some more.

  * use ${perl:Depends} with dh_perl to handle the depends in control.

  * remove the:
## All lines beginning with `## DP:' are a description of the patch.
    lines from all dpatches.

rest seems to be good, i'll check again if you fixed above things, and
if good, will sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: