Re: RFC: id3tool (updated package - adoption)

[Daniel Baumann <daniel@debian.org>]

Paul Cager wrote:
> http://mentors.debian.net/debian/pool/main/i/id3tool/id3tool_1.2a-1.dsc

generally the package is good, but there are a few glitches i would correct:

you write:

---snip---
  * New maintainer. (Closes: #400360 - ITA: id3tool)
  * New upstream release (Closes: #280180 - Option -c can only be first
parameter)
  * Correct spelling mistake (Closes: #363953)
---snap---

i would write:

---snip---
  * New maintainer (Closes: #400360).
  * New upstream release:
    - Option -c can only be first parameter (Closes: #280180).
  * Corrected spelling mistake (Closes: #363953).
---snap---

you write:

---snip---
Homepage: http://nekohako.xware.cx/id3tool/index.html
---snap---

i would write:

---snip---
Homepage: http://nekohako.xware.cx/id3tool/
---snap---

additionally:

  * copyright contains a useless empty line at the end of the file.
  * dirs is useless, the build system just creates the directory on its
    own.

if you fix above things, i'm happy to sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/