Re: RFS: vrms (updated package)

[Daniel Baumann <daniel@debian.org>]

Rogério Brito wrote:
> Thank you very much for the review. It is one of the things that I was
> looking for, since I want to use the best-current practices.

well, you could do it much better, if you care..

  * since you don't build anything in build:, you can just write

---snipp---
build:
---snapp---

    in your rules, instead of

---snipp---
build: build-stamp
build-stamp:
        dh_testdir
        touch build-stamp
---snapp---

  * install-stamp isn't required

---snipp---
install: build
---snapp---

   in your rules, instead of

---snipp---
install: install-stamp
install-stamp: build-stamp
---snapp---

  * installing with -o and -g is useless, will be fixed by dh_fixperms
    later anyway.

  * dh_installmenu is useless, you don't have any menu anyway.

....and remove the useless empty line at the end of README.Debian.

tell me if you care for these things and want to fix them, or if i
should upload the current one.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/