Re: html2ps heads-up

[Antony Gelberg <antony@wayforth.co.uk>]

Russ Allbery wrote:
> Antony Gelberg <antony@wayforth.co.uk> writes:
> 
> 
>>Okay, they build on pbuilder and are on m.d.n.
> 
> 
>>I would be grateful for a sponsor to have a look at, and hopefully, to
>>upload the packages.
> 
> 
> It looks like there are several changes you made to the package that
> aren't documented in debian/changelog.  Please document all of your
> changes there.
> 
> --- html2ps-1.0b5/html2ps
> +++ html2ps-1.0b5/html2ps
> @@ -1,4 +1,4 @@
> -#! /usr/bin/perl
> +#!/usr/bin/perl
>  
>  # This is html2ps version 1.0 beta5, an HTML-to-PostScript converter.
>  #   Copyright (C) 1995-2005 Jan Karrman.
> 
> Not that it matters for Debian, but this change actually reduces
> portability.  (Both versions are equivalent on Debian, which only uses
> modern kernels.)
> 
> --- html2ps-1.0b5/contrib/xhtml2ps/xhtml2ps
> +++ html2ps-1.0b5/contrib/xhtml2ps/xhtml2ps
> @@ -376,7 +376,7 @@
>    #############################################################################
> #
>    #
>  proc PR_Box {{language "EN"} \
> -             {printcmd "lp"} \
> +             {printcmd "lpr"} \
>               {filepcmd "exec cp"} \
>               {filename ""}} {
>    global prdata
> @@ -805,7 +805,7 @@
>      command     "html2ps"
>      checker     "weblint -x Netscape"
>      viewer      "ghostview -magstep -2 -a4"
> -    printcmd    "lpr"
> +    printcmd    "lp"
>      filepcmd    "exec cp"
>      orientation " "
>      colonnes    " "
> 
> Why lpr in one place and lp in another?  (There may be a good reason.  I
> just can't follow well enough in the code to know what it might be.)
> 
> Other than that, this looks fine.  I'd be willing to sponsor it with those
> changes.
> 

Hmm.  I thought I'd diffed the old and new.  Thanks for the catch and
the offer.  I'll fix the packages tonight, re-upload, and let you know.

Antony