On Sun, 12 Mar 2006, Don Armstrong wrote: > On Sun, 12 Mar 2006, Michael Spang wrote: > > Michael Spang wrote: > > > > > Package name : firefox-greasemonkey > > > Version : 0.6.4 > > > Upstream Author : Aaron Boodman > > > URL : http://greasemonkey.mozdev.org/ > > > License : No restrictions > > > Description : firefox extension which enables customization of > > > webpages with user scripts > > > > > > Greasemonkey allows users of the Firefox web browser to create or > > > download > > > user scripts which modify the content or behavior of web sites. It > > > provides a > > > powerful way to personalize the web. The scripts are written in > > > Javascript and > > > have access to many of Firefox's features. A large collection of > > > prewritten scripts > > > can be found at userscripts.org > > > > I posted this back in December of 2005. Are any sponsors who missed the > > original interested? > > The ITP is #341915 and the package is at > > http://mentors.debian.net/debian/pool/main/g/greasemonkey/ > > I actually was looking at this earlier, so I'm interested in > sponsoring it... I'll take a look at your packages in just a bit. Ok, a couple of major/minor issues: 1) You're just providing the xpi file instead of building it from the individual source packages which are present in the upstream source. You need to write your own makefile/installer which builds the xpi instead or installs it to the proper location. Don't forget to include whatever is building the .xpt xpcom files too. 2) The short description should be a bit more verbose, your ITP description is much better than the one in control. 3) You should be using debhelper 5 with appropriate compat levels. Don Armstrong -- There is no mechanical problem so difficult that it cannot be solved by brute strength and ignorance. -- William's Law http://www.donarmstrong.com http://rzlab.ucr.edu
Attachment:
signature.asc
Description: Digital signature