Re: Beginner Maintainer: tremulous-editor, tremulous-mappack
Salokine wrote:
> You can find it on Debian Mentors web site:
at least give the URI to the *.dsc, i don't want to fire up
${www-browser} just because of you.
> http://mentors.debian.net/debian/pool/main/t/tremulous-editor
* package should be non-native.
* README and README.Debian are useless, doesn't contain any
information at all.
* why priority extra?
* it should be debhelper (>= 5), not debhelper (>=5),
and tremulous (>= 1.1.0), gtkradiant (>= 1.5.0)
not tremulous (>=1.1.0), gtkradiant (>=1.5.0).
* short and long descriptions must be improved/extended a lot.
* do you have no own website, do you really want to do the primary
distribution through ftp.debian.org?
* your copyright is incomplete, there is other code with different
authors/license in the tarball. you need to list that too. look
at tineyerp-client from unstable for an example how to do
multi-authors/multi-license copyright files properly.
* dirs is useless here.
* docs is empty, hence useless.
* your package is only building one binary-package, hence i do
recommend to not mix prefixed helpers and not prefixed.
therefore, rename tremulous-editor.dirs to dirs.
* remove the commented useless things in rules
* if you don't do something in configure:, remove it completely.
* if you don't do something in buid:, replace it with this:
---snip---
build:
---snap---
* remove the commented useless dh_* calls.
> http://mentors.debian.net/debian/pool/main/t/tremulous-mappack
* package should be non-native.
* README and README.Debian are useless, doesn't contain any
information at all.
* why priority extra?
* it should be debhelper (>= 5), not debhelper (>=5),
and tremulous (>= 1.1.0), not tremulous (>=1.1.0).
* improve/extend long description, and fix the following ugly things:
- don't do two empty lines (.), one is just enough
- wrap the lines after 80 chars.
- the homepage entry should be:
---snip---
Homepage: http://www.bricosoft.com
---snap---
note the two leading spaces.
* your copyright file is incomplete.
* i hardly believe that the *.pk3 are source (the form prefered to do
modifications). please explain this. depending on your answer,
you will have some problems with the licensing too (GPL is quite
restrictive in this perspective).
* dirs is useless here.
* docs is empty, hence useless.
* your package is only building one binary-package, hence i do
recommend to not mix prefixed helpers and not prefixed.
therefore, rename tremulous-mappack.dirs to dirs.
* remove the commented useless things in rules
* if you don't do something in configure:, remove it completely.
* if you don't do something in buid:, replace it with this:
---snip---
build:
---snap---
* remove the commented useless dh_* calls.
so far the debian packaging point of view. for the upstream things, i
recomend you to not write /bin/bash in your scripts when they're not
using any bash-only feature (e.g. update.sh).
fix at least the above mentioned debian packaging issues should be fixed
before asking for a second review.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: