Re: RFC: libinstrudeo1
On Tuesday 21 November 2006 15:38, Daniel Baumann wrote:
> Luca Bedogni wrote:
> > http://mentors.debian.net/debian/pool/main/l/libinstrudeo/
>
> * you did modify Makefile.in and configure, this is not noted in the
> changelog. was it done on purpose?
Nope, i restored them
> * README.Debian is empty, remove it.
Done
> * remove the useless empty line at the end of changelog
Done
> * why priority extra?
Changed to optional. Is that correct?
> * ${misc:Depends} is useless here
Removed
> * libinstrudeo-dev should depend on libstrudeo1 ${source:Version}
Done
> * your copyright lacks the required information, look at libquicktime
> from experimental to get a sane example.
Yeah i've missed it, now i think it's ok..
> * debian/*dirs is not used here, remove it.
Done
> * README does not contain usefull information, remove it from docs.
Removed
> * /usr/lib/*.so belongs to the -dev package, not the lib package.
>
> * cleanup your rules, look at libquicktime from experimental for an
> example.
Mmm... What's wrong with the rules file?
> * the /usr/lib/*.la belongs to the -dev package, why do you exclude
> it?
Now it's in it :)
> * the package doesn build, you build-depends lacks a bunch of required
> libraries. please make *always* sure you are compiling in a sid
> chroot (e.g. with pbuilder or other tools).
Yeah i used pbuilder and filled build-depends..
> if you fixe above things, i'll sponsor it.
Ok uploaded new version. Please recheck it if i've done all the things you
said..
Regards
--
Debian Powered GNU/Linux User #373118
Bedogni Luca - Blog | http://blog.lucabedogni.it
Site | http://www.lucabedogni.it
Debianizzati - www.debianizzati.org | Founder Member
--
Don't anthropomorphize computers. They don't like it.
Reply to: