Re: RFS: gcin

[Daniel Baumann <daniel@debian.org>]

caleb wrote:
> I would be glad if someone uploaded this package for me. :-)

  * your build is unclean, .depends is a left over, remove it in clean:.
  * remove the useless empty line at the end of the changelog.
  * debhelper (>= 5.0.0) is over-precise, write debhelper (>= 5)
  * this is wrong:

---snipp---
 Home Page: http://www.csie.nctu.edu.tw/~cp76/gcin/
---snapp---

    and this is right:

---snipp---
  Homepage: http://www.csie.nctu.edu.tw/~cp76/gcin/
---snapp---

   note the *two* leading spaces.

  * your package is building multiple binaries, hence for some debhelper
    meta-files you do prefix them with the package name (such as
    gcin-qt3-immodule.install). please do it for all meta-helpers, this
    means your install, menu, post*, pre* files should get a prefix too.

  * this is ugly:

---snip---
#! /bin/sh /usr/share/dpatch/dpatch-run
---snapp---

    and this is beautiful:

---snipp---
#!/bin/sh /usr/share/dpatch/dpatch-run
---snapp---

  * fix the patch author information in all dpatches. it should be:

---snip---
## 10_some-patch.dpatch by Example Developer <developer@example.com>
---snapp---

the rest is good. once you correct this, i'm happy to sponsor the package.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/