[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sqwebmail-de: german templates for sqwebmail (fixes RC-bug)



Daniel Baumann wrote:
> Going now to bed, will take care tomorrow.

ok, here we go:

  * '* Old changelog entries just for history.' is not needed in
     changelog, we do always keep the old changelog, even if the package
     was completely remade.
  * remove the useless empty line at the end of the changelog.
  * debhelper (>= 5.0.0) is over-precise, use debhelper (>= 5) instead.
  * Standards-Version: 3.7.2.2 is over-precise, use
    Standards-Version: 3.7.2 instead.
  * After Description:, there are two spaces instead of just one.
  * Before Hompepage:, there must be two leading spaces, not just one.
  * debian/copyright is a bit strange formated, and there is no full
    GPL blurb. look at e.g. libquicktime in experimental how to do it
    right.
  * cleanup your rules a bit:

remove this:
---snipp---
# -*- makefile -*-
# Sample debian/rules that uses debhelper.
# This file was originally written by Joey Hess and Craig Small.
# As a special exception, when this file is copied by dh-make into a
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of
dh-make.
---snapp---

what's that intended to be good for?
---snipp---
#CONFIGURE#
---snapp---

remove this under build:
---snipp---
# Add here commands to install the package into debian/tmp
---snapp---

remove the empty line above:
---snipp---
mkdir -p $(ROOT)/usr/lib/courier/sqwebmail/html/de-de
---snapp---

  * additionally, there is a new upstream release available, you may
    want to upgrade.

if you fixed above things, i'm happy to sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: