Hi James, Thanks for reviewing another package. Op do, 21-09-2006 te 17:31 +0100, schreef James Westby: > Hi, > > Apologies that it took me a while to get to this package, it is more > complex than the other two, and put me off each time I came to it until > now. Hehe, It also took me some time to make it. > The package looks good, apart from two things, > > * When using ${binary:Version} or ${source:Version} you need to add a > versioned build-dep on dpkg-dev, see > http://lists.debian.org/debian-mentors/2006/09/msg00228.html > Note that this may apply to your other packages, could you please > check? It only got added to my mental checklist recently. Hmpf, Thanks for noticing this. I have updated the package. New version is available from my repository [1]. > * Your debian/copyright appears correct, but what worries me is that > the upstream files say > "License : BSD3; see COPYRIGHT file for terms and conditions" > but the COPYRIGHT file doesn't contain BSD3. Is it worth seeking > clarification? Indeed. Again thanks for noticing. I will ask upstream. > The packages look good overall. I hope you find a sponsor. Thanks. Greetings Arjan [1] dget http://moonshine.dnsalias.org/debian/unstable/haskell-edison_1.2.0.1-2_i386.changes
Attachment:
signature.asc
Description: Dit berichtdeel is digitaal ondertekend