Re: RFS: lopster (updated package)
On Sunday 03 September 2006 00:13, Francesco Namuri wrote:
> On Sat, Sep 02, 2006 at 07:54:05PM +0200, Christoph Haas wrote:
> > Also strange that I can't find an entry in my KDE start menu. I had
> > expected it under Debian->Applications->Network but it's not there.
> > Perhaps not your fault. But as I'm at it already: consider providing a
> > *.desktop file so it will show in e.g. KDE, too, in the proper
> > location.
>
> ok, I have added the lopster.desktop file and the lopster.xpm icon.
> hoping it's ok... :)
I think so. But please do not put them into the upstream's directory.
Everything that you add to the software to make it a Debian package should
stay in the debian/ directory. Except perhaps config.guess and such files
that you changes on purpose.
Just checked which files you change that are outside the debian/ directory:
zcat lopster_1.2.2-2.diff.gz | grep ^--- | grep -v debian
--- lopster-1.2.2.orig/aclocal.m4
--- lopster-1.2.2.orig/m4/Makefile.in
--- lopster-1.2.2.orig/Makefile.am
--- lopster-1.2.2.orig/config.h.in
--- lopster-1.2.2.orig/src/log.c
--- lopster-1.2.2.orig/Makefile.in
--- lopster-1.2.2.orig/configure
--- lopster-1.2.2.orig/lopster.xpm
--- lopster-1.2.2.orig/stamp-h
--- lopster-1.2.2.orig/lopster.desktop
I don't think that these files should be changed. Please
read "zless /usr/share/doc/autotools-dev/README.Debian.gz" on how to deal
with autotools-built packages.
If you feel you need to change source files (like src/log.c) then please
use some patch manager. I personally prefer "dpatch" - others use "quilt".
Otherwise you will have trouble once a new upstream version is released
because you need to find out which parts you had changed.
> I hope not to have done too many mistakes with my ugly English... :)
Stay a while in some IRC channels and then judge your english again. :)
Cheers
Christoph
--
~
~
".signature" [Modified] 1 line --100%-- 1,48 All
Reply to: