[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS (dget optimized): subcommander -- qt based multiplatform subversion client, diff & merge tool



On Tue, Jul 25, 2006 at 12:08:29PM +0200, Andreas Fester wrote:
> * Package name    : subcommander
> * License         : GNU/GPL

I didn't really look at the package, just at the copyright file.  The reason
is that you said GNU/GPL, which is incorrect.  "GNU/Linux" means "a
combination of the GNU system and the Linux kernel".  "GNU GPL" means "the
GPL, as part of the GNU system", similar to "GNU Emacs" or "the GNU C
compiler".  There is no such thing as "GNU/GPL".

The copyright file doesn't contain this error, so that's fine.  However, it
also doesn't contain the recommended paragraph from the GPL itself (the thing
which should also be at the top of every source file).

The source files instead point to doc/COPYING, which contains it, so I suppose
that is fine.  However, you should have the full contents of it in
debian/copyright as well, because it is installed in the binary package so
users know the copyright without first getting the source.  In particular,
there is an exception for linking to Qt, which you don't even mention in
debian/copyright.  Such mistakes can easily be avoided by copy+pasting the
contents into debian/copyright.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://129.125.47.90/e-mail.html

Attachment: signature.asc
Description: Digital signature


Reply to: