[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: The bobcat library



On Friday 30 June 2006 13:54, Frank B. Brokken wrote:
> Dear list / Debian Sponsors,

Hello Frank,
	I couldn't sponsor your work (still in NMq;-), but here are some minor 
comments you might find useful. Also check your other packages against these 
considerations.

>     I'm looking for a sponsor and advocate for my `Bobcat' library, which
> is used by, e.g., my programs bisonc++ and stealth, subitted separately. 
> You'll find the details about the Bobcat library below. Don't hesitate to
> contact me if there are any questions or remarks related to the Bobcat
> library.
>
> Packages:           libbobcat1, libbobcat1-dev
> License:            Academic Free License

I didn't bother to read the AFL 2.1 yet, but it is good idea to verify its 
DFSG compliance and if case of need... well ... just relisence your code. If 
in doubt contact debian-legal mailing list.

--cut--
Your debian/changelog claims unstable, but the package doesn't seem to be 
built with a compiler from sid, so use that one to compile with:

FTBFS (g++ 4.1 from Sid):
g++ -I../tmp -Wall -O3 -o o/1breakdown.o -c breakdown.cc
../tmp/bobcat/errno:34: error: extra qualification ‘FBB::Errno::’ on 
member ‘initMsg’
make: *** [build-stamp] Error 1

The fix is trivial ... as you know ;)
diff -Naur errno/errno.orig errno/errno
--- errno/errno.orig    2006-06-30 16:08:31.000000000 +0300
+++ errno/errno 2006-06-30 16:08:44.000000000 +0300
@@ -31,7 +31,7 @@
             }

         private:
-            void Errno::initMsg();
+            void initMsg();
     };

     inline std::ostream &insertable(std::ostream &errnoObject)



Fix these soft of errors also for:
log/log
pattern/pattern
string/string

OTOH the code appears to be very clean and compact!

-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB 



Reply to: