[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gtkradiant



On Tuesday 27 June 2006 11:58, George Danchev wrote:
> On Sunday 25 June 2006 17:11, Frits Daalmans wrote:
> > From: Frits Daalmans <fritsd@wanadoo.nl>
> > To: debian-mentors@lists.debian.org
> > Subject: RFS: gtkradiant
> >
> > Dear mentors,
>
> Hi,
>
> > I am looking for a sponsor for my package "gtkradiant".
> >
> > * Package name    : gtkradiant
> >   Version         : 1.5.0-1
> >   Upstream Author : Id Software, Inc. and contributors
> > * URL             : https://zerowing.idsoftware.com/svn/radiant
> > * License         : mostly GPL, parts BSD, LGPL
> >   Section         : games
> >
> > It builds these binary packages:
> > gtkradiant - Level editor for Quake 4 and Doom 3
> >
> > The package is practically lintian clean.
>
> 1) lintian -i ../gtkradiant_1.5.0-2_i386.deb
> E: gtkradiant: copyright-should-refer-to-common-license-file-for-gpl
> N:
> N:   The string "GNU General Public License" or "GPL" appears in the
> N:   copyright file for this package, but the copyright file does not
> N:   reference /usr/share/common-licenses as the location of the GPL on
> N:   Debian systems.
> N:
> N:   Refer to Policy Manual, section 12.5 for details.
> N:
> W: gtkradiant: extended-description-line-too-long
> N:
> N:   One or more lines in the extended part of the "Description:" field
> N:   have been found to contain more than 80 characters. For the benefit of
> N:   users of 80x25 terminals, it is recommended that the lines do not
> N:   exceed 80 characters.
> N:
> N:   Refer to Policy Manual, section 3.4.1 for details.
> N:
>
> These are easy to deal with...
Thank you for your time!
Lintian is now happy and I've done an upload to version 1.5.0-3 
to mentors.debian.net
>
> 2) FTBFS
> contrib/bobtoolz/DMap.h:47: error: extra qualification ‘DMap::’ on
> member ‘GetEntityForID’
> include/ibrush.h: In constructor ‘_QERFaceData::_QERFaceData()’:
> include/ibrush.h:96: warning: ‘_QERFaceData::value’ will be initialized
> after include/ibrush.h:93: warning:   ‘const char* _QERFaceData::m_shader’
> include/ibrush.h:86: warning:   when initialized here
> scons: *** [build/release/contrib/bobtoolz/DMap.os] Error 1
> scons: building terminated because of errors.
> make: *** [build-stamp] Error 2
"it never does that when I compile it" :-) (really!)
corrected with your dpatch. I compiled it with 
$ g++ --version
g++ (GCC) 4.0.4 20060507 (prerelease) (Debian 4.0.3-3)


>
>
> You can fix this by the following dpatch:
> @DPATCH@
> diff -urNad gtkradiant-1.5.0~/contrib/bobtoolz/DMap.h
> gtkradiant-1.5.0/contrib/bobtoolz/DMap.h
> --- gtkradiant-1.5.0~/contrib/bobtoolz/DMap.h   2006-05-14
> 20:15:00.000000000 +0300
> +++ gtkradiant-1.5.0/contrib/bobtoolz/DMap.h    2006-06-27
> 12:55:20.000000000 +0300
> @@ -44,7 +44,7 @@
>         DEntity* GetWorldSpawn();
>         void ClearEntities();
>
> -       DEntity* DMap::GetEntityForID(int ID);
> +       DEntity* GetEntityForID(int ID);
>         DEntity* AddEntity(char* classname = "worldspawn", int ID = -1);
>
>         std::list<DEntity*> entityList;
>
> 3) g++-4.x is not so happy with the source - too much signess and incompat
> pointer type warnings are being emitted...
True.. I'll take a look if I can clean it up further. 
>
> --
> pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
> fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB

Attachment: pgpDcX3hUf6Vc.pgp
Description: PGP signature


Reply to: