On Fri, Nov 04, 2005 at 02:22:27PM -0500, pryzbyj wrote:
> On Fri, Nov 04, 2005 at 04:07:39PM -0300, Margarita Manterola wrote:
> > Hi!
> >
> > I have prepared a package for the linsmith application. It's an
> > application for electrical engineers that allows to create smith
> > charts, and it's much better than the one already in Debian
> > (xsmc-calc).
> >
> > The packages are located at:
> > http://www.marga.com.ar/~marga/debian/linsmith/
> >
> > They are lintian clean, and they build fine inside a pbuilder. I'd
> > need someone to please sponsor the upload. Thank you.
> Your .diff is 844K, for a 1.4MB .orig. Surely this is a mistake. I'm
> retrieving a copy now for further inspection.
Okay, its a uuencoded PDF file. Remove that and the .diff.gz is only
26KB. You'll want to generate the PDF from source, if at all
possible. Where are you getting the ./debian/manual.pdf.uu? Is it an
updated copy? Why isn't it distributed with upstream?
Other comments:
./debian/control:
Description: a program to make Smith Charts
I would suggest "a tool to generate Smith Charts", since most of
Debian is "program", for at least somebody's definition of program.
Long description:
I would suggest explaining what a Smith Chart is somewhere other than
the first sentence, which should be specific to this tool. See the
Developers Reference for such best practices.
Instead of "linsSmith's website:", I would prefer "Homepage:", as per
convention.
./debian/linsmith.doc-base:
The abstract should include some technical detail.
./debian/rules:
You might consider including the list of documentation on the
commandline for dh_installdocs, rather than in a separate file.
Same for dh_installdirs.
You might also consider *removing* config.{sub,guess} in the clean
target, rather than copying them. This makes the .diff easy to read,
which is important IMHO. Then you will want to copy or symlink them
somewhere in the configure target (or a dependency thereof).
Use of dpatch: good; I haven't gotten to be comforable with this, yet.
So, the only big problem is that PDF file. You will want to generate
it from source, which will make the .diff much smaller, and also means
that the source is actually included, and the generated files are
actually generated by building. Remember to update build-deps as
necessary.
(I'm not a DD, yet, so I can't upload for you, though).
--
Clear skies,
Justin