Re: "Cannot represent change" error upon PNG file addition
On Thu, 2004-12-09 at 16:24, Don Armstrong wrote:
> On Thu, 09 Dec 2004, Christoph Berg wrote:
> > Re: Nick Lewycky in <[🔎] 41B76EF8.20603@mxc.ca>
> > > >--- /usr/bin/dpkg-source 2004-11-11 21:15:52.000000000 +0100
> > > >+++ /home/ifi/bin/dpkg-source 2004-12-08 14:45:00.000000000 +0100
> > > >@@ -406,7 +406,7 @@
> > > > $ENV{'LC_ALL'}= 'C';
> > > > $ENV{'LANG'}= 'C';
> > > > $ENV{'TZ'}= 'UTC0';
> > > >- exec('diff','-u',
> > > >+ exec('diff','-au',
> > >
> > > That's terrifying. I just tried diff -a on two PNG files and it worked
> > > just fine. But will it always work?
> >
> > This breaks your package for all people that are not using a patched
> > dpkg-source. They can't unpack/pack it. Don't do it.
>
> They can unpack it, but they won't be able to pack it.
>
> But that's besides the point. I'm personally interested in other valid
> reasons to avoid using diff -au; since I personally haven't seen any
> reason to avoid using this option yet.
It makes reading diffs or applying parts of them by hand a bigger pain.
less will complain about binary data, other viewers (more, most, gedit,
I don't know what else people are using these days) probably handle it
even less gracefully.
(I have no strong opinion one way or another -- I'm fine skipping past
binary parts, and being able to include non-uuencoded binaries is a
pretty cool deal. It works around one of my least-favorite packaging
tasks. But then, skipping past binary diffs would probably become my new
least-favorite task.)
--
Joe Wreschnig <piman@debian.org>
Reply to: