On Tue, May 04, 2004 at 10:46:50PM +0200, Andreas Metzler wrote:
> > 2) csmash - a table tennis simulation game
> > I've fixed one outstanding bug and I like this game very much ;)
> [...]
>
> Hello,
> I have taken a short peek at this one and have some
> questions/critizism:
First of all thanks for your suggestions and interest.
> #1 I've compared -2 and -3 with interdiff and realized that you have
> dumped the patch to loadparts.cpp. Why? I do not speak C++ but afaict
> this will reopen #141921.
Hmm... well... I haven't dumped anything. Especially patches.
Which versions have you compared?
I started working with `apt-get source csmash` and there are no patches
in debian subdirectory.
Maybe there were merged to upstream version so far?
> #2 The generation of the arch all part in debian/rules is broken. You
> generate it in in the binary-arch target, and therefore all the
> buildds will uselessly build it (check dpkg-buildpackage -B). You have
> to generate it in the binary-all target. - Basically you just copy all
> the commands listed in binary-arch to binary-all, and add -a to all
> debhelper invocations in binary-arch and -i to all in binary-indep and
> throw out the unnecesary ones.
Yes. This sound very reasonable. I'll fix it tomorrow. Now have to get
some sleep. But thanks for pointing it out to me.
> #3 You might want to update config.(sub|guess) from autotools-dev
> while you are at it.
Yes. This would be fixed tomorrow too.
Thanks a lot for comments.
regards
fEnIo
--
_ Bartosz Fenski | mailto:fenio@o2.pl | pgp:0x13fefc40 | IRC:fEnIo
_|_|_ 32-050 Skawina - Glowackiego 3/15 - w. malopolskie - Polska
(0 0) phone:+48602383548 | Slackware - the weakest link
ooO--(_)--Ooo http://skawina.eu.org | JID:fenio@jabber.org | RLU:172001
Attachment:
signature.asc
Description: Digital signature