[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: fityk - general-purpose nonlinear curve fitting and data analysis

"Carlo U. Segre" <segre@iit.edu> wrote:

> Hello All:
> I am looking for a sponsor for the following package:
> Package:        fityk
> Author:         Marcin Wojdyr <wojdyr@if.pw.edu.pl>
> URL:            http://www.unipress.waw.pl/soft/crystallography/fityk/
> License:        GPL
> Debian Packages:  deb-src http://fermi.phys.iit.edu/debian/sid source/
>                    deb http://fermi.phys.iit.edu/debian/sid binary/

Some remarks:

- you should file an ITP bug against wnpp (and close it in the

- Upstream should not just put a copy of the GPL into the tarball, but
  state somewhere that he wants this license to be applied to the work.

- debian/copyright: 

"Copyright: GNU Ceneral Public License" is wrong. Copyright indicates
the owner of the copyright, i.e. the upstream author. After that, you
should put something like 

| This is free software; you can redistribute it and/or modify it under the
| terms of version 2 of the GNU General Public License as published by the
| Free Software Foundation.
| This is distributed in the hope that it will be useful, but WITHOUT
| ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
| FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
| for more details.

- debian/fityk.1:

Have you submitted the manpage upstream?

- debian/control:

You should use the current standards-version, there might also some
changes be needed for this (upgrade-checklist.txt.gz).

- debian/rules:

  * See section 10.1 of Policy for the CFLAGS setting
  * Please remove the commented lines 

Besides that, it looks nice.

Regards, Frank
Frank Küster, Biozentrum der Univ. Basel
Abt. Biophysikalische Chemie

Reply to: