[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Could someone check this package (osdsh)?



Hi,

Am Mi, den 22.10.2003 schrieb Steve Kemp um 15:21:
> On Wed, Oct 22, 2003 at 02:39:34PM +0200, Joachim Breitner wrote:
> > I just became a full Debian Developer, so don't worry, you don't have to
> > sponsor anything and all that goes wrong will be blamed on me...
>   Congratulations :)
Thanks-

>    The main source file isn't readable, so I couldnt' download it.
Wrong perms, fixed.

>  1. The code compiles with -O3 not -O2 which I think is the
>     suggested value.
> 
>  2. The osdctl binary segfaults on excessive command line args.
>     (Unbounded sprintf's in src/osdctl/osdctl.c).
I will file a forwarded bug as soon as it shows up in the BTS.

>  3. The first line of the description reads:
>  	"Overlays your screen with various system informations"
>     I'd remove that trailing "s", to read "system information".
Done

>  4. The long discription could be cleaned a little too...
WRT formatting or content or language?

>   All in all a good job for a first attempt :)
It is actually the second, but thanks anyways :-)

nomeata
-- 
Joachim "nomeata" Breitner
  e-Mail: mail@joachim-breitner.de | Homepage: http://www.joachim-breitner.de
  JID: joachimbreitner@amessage.de | GPG-Keyid: 4743206C | ICQ#: 74513189
  Geekcode: GCS/IT/S d-- s++:- a--- C++ UL+++ P+++ !E W+++ N-- !W O? M?>+ V?
            PS++ PE PGP++ t? 5? X- R+ tv- b++ DI+ D+ G e+>* h! z?
Bitte senden Sie mir keine Word- oder PowerPoint-Anhänge.
Siehe http://www.fsf.org/philosophy/no-word-attachments.de.html

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


Reply to: