Re: Need experienced perl module maintainer for a second pair of eyes on my package
Hi,
I looked at your package and have following comments and suggestions:
- The Build-Depends should be on debhelper (>= 3.0.18) per policy.
- Why is there an empty /usr/lib/perl5 directory in your package?
- Please remove the 'local' at the bottom of the changelog (using
the dpkg-dev-el package automatically takes care of this).
- The debian/rules is not in accordance with the Perl Policy, e.g
you shouldn't define PERL, the 'make install' contains more than
necessary, the 'make' shouldn't define the LD_RUN_PATH, you define
INSTALLDIRS=perl5 but you don't use it, etc. I would suggest to
take a look at one of my packages for ideas.
- You should also install the upstream Changes.
- Please also consider to install the README for completeness.
By the way, is this a Debian only package? I noticed you had the debian
directory in the .orig.tar.gz file and als a diff file.
Thanks,
Ardo
i-Marc Haber (debian-mentors.lists.debian.org@marc-haber.de) wrote:
> Hi,
>
> I don't have any experience with perl module packages, and I usually
> work under potato which has a quite different perl policy. I'd
> appreciate if anybody who knows how to build perl packages on sid
> would take a look at my libnet-ipnetmember-perl package from
> http://q.bofh.de/~mh/debian/libnet-ipnetmember-perl/.
>
> The package builds OK on sid, the module is useable after
> installation, and lintian doesn't have any complaints. Did I miss some
> parts of perl policy, or can the package be uploaded to the archive in
> this form?
>
> Any hints will be appreciated.
>
> Greetings
> Marc
>
> --
> -------------------------------------- !! No courtesy copies, please !! -----
> Marc Haber | " Questions are the | Mailadresse im Header
> Karlsruhe, Germany | Beginning of Wisdom " | Fon: *49 721 966 32 15
> Nordisch by Nature | Lt. Worf, TNG "Rightful Heir" | Fax: *49 721 966 31 29
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-request@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
>
--
Ardo van Rangelrooij
home email: ardo@debian.org
home page: http://people.debian.org/~ardo
GnuPG fp: 3B 1F 21 72 00 5C 3A 73 7F 72 DF D9 90 78 47 F9
Reply to: