[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: NGMLR update - catching division by 0



Hi Steffen,

On Thu, 15 Jul 2021 at 00:21, Steffen Möller <steffen_moeller@gmx.de> wrote:
Hello,

I had some fun with https://salsa.debian.org/med-team/ngmlr/ and helped upstream with the VA_ARGS in the preprocessor macros a bit more. This was all triggered by a division by 0 error that affected us locally and was fixed in a user-contributed patch in May (https://github.com/philres/ngmlr/pull/96). Some wording in another github issue had made me believe that the patch was already adopted in some other form, but it wasn't. I have now updated to that latest -dev version which I now wish I had not done.

Anyway. The type error reported and fixed by Nilesh no longer surfaces and said patch also interferes with the handling of variable length arguments, so I disabled that one.

I'm a bit worried -- was that patch wrong somehow? (for the previous release?)
Although the autopkgtests run with various args, I'm not sure there -- mind explaining?
 
@Nilesh, I interpret va_start differently and please kindly check with said patch enabled that --version truly prints the version and not the format string with the %s placeholder.

As you might see on salsa-CI, the build fails because you did not commit and push ngmlr/debian/patches/AlignmentBuffer_noMatch.patch
I can't test something that I can't build :-)
Can you plese fix this and push?

Also, in the debian/patches/VarArgsDefines.patch Forwarded field looks like you forwarded in to *"your own repository"* (https://github.com/smoe/ngmlr/pull/1) can you fix this?

Nilesh

Reply to: