NGMLR update - catching division by 0
Hello,
I had some fun with https://salsa.debian.org/med-team/ngmlr/ and helped upstream with the VA_ARGS in the preprocessor macros a bit more. This was all triggered by a division by 0 error that affected us locally and was fixed in a user-contributed patch in May (https://github.com/philres/ngmlr/pull/96). Some wording in another github issue had made me believe that the patch was already adopted in some other form, but it wasn't. I have now updated to that latest -dev version which I now wish I had not done.
Anyway. The type error reported and fixed by Nilesh no longer surfaces and said patch also interferes with the handling of variable length arguments, so I disabled that one. @Nilesh, I interpret va_start differently and please kindly check with said patch enabled that --version truly prints the version and not the format string with the %s placeholder.
Best,
Steffen
Reply to: