Hi Shruti, On 5/20/21 4:56 PM, Shruti Sridhar wrote: > Hi, > > I have added autopkgtests for prime-phylo. > (https://salsa.debian.org/med-team/prime-phylo) > Kindly review and sponsor Looks nice. However, * We are in deep freeze right now[1] I'll happily sponsor when bullseye is out. * You have added checksum comparision, nice. However this might fail on some !amd64 arches due to float precision errors. I think it'd be better if md5sums are compared only on amd64 and simply check that the output file is not empty on other architectures - consider making that change in the run-unit-test script. Stringtie unit test might serve as an example here[2] * Please keep adding a d/salsa-ci.yml, for packages you are working on, if not already present. I added for this one for now it fails reprotest unfortunately, I'm not sure of a way to fix this right now. It is not very important however. [1]: https://release.debian.org/bullseye/freeze_policy.html [2]: https://salsa.debian.org/med-team/stringtie/-/blob/master/debian/tests/run-unit-test Nilesh
Attachment:
signature.asc
Description: OpenPGP digital signature