Re: [RFS] and peer review: mosdepth

[Steffen Möller <steffen_moeller@gmx.de>]

On 03.11.20 23:23, Nilesh Patra wrote:
>
>
> On Wed, 4 Nov, 2020, 3:24 am Steffen Möller, <steffen_moeller@gmx.de
> <mailto:steffen_moeller@gmx.de>> wrote:
>
>     It took me a while but at some point I have understood that the
>     package
>     was already uploaded. I added the -d:release and added some bits to
>     auto_clean.
>
>
> Thanks!
>
>
>     Now,
>
>     dpkg-buildpackage && ./debian/rules clean
>
>     will bring this git status:
>
>     Changes not staged for commit:
>      (use "git add/rm <file>..." to update what will be committed)
>      (use "git restore <file>..." to discard changes in working directory)
>            deleted:    tests/missing.bed
>
>
> That's because of this line I added to d/rules[1]
> This is because missing.bed is an empty file and installing it isn't
> sensible - which a lintian warning signalled as well.
>
> [1]: https://salsa.debian.org/med-team/mosdepth/-/blob/master/debian/rules#L18
> <https://salsa.debian.org/med-team/mosdepth/-/blob/master/debian/rules#L18>
>
>
>     I added this to d/copyright's Files-Excluded - was that correct?
>
>
> As of now, no - since I didn't repack this, just removed it during
> testing - I thought that some tests are using this file but I was
> wrong to assume so.
>
> Repacking this again would mean switching to a +dfsg.1 version - maybe
> adding this to files-excluded with the next upstream release could be good

That is how it was meant. Routine-update should read this now and then
prepare the next version without that file.

I am not sure if that is the right thing, though. If there is a test
against an empty file then this is what it should be and we should
override the lintian warning.

I am more than happy with mosdepth for now and will next address the
missing packages for the hts-nim-tools. Many thanks!

Steffen