[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#972004: Assembly code not working for mips64el and ppc64el (Was: Bug#972004: bowtie ftbfs on several release architectures)



Hi Andreas,

Andreas Tille, on 2020-10-13 14:06:03 +0200:
> On Tue, Oct 13, 2020 at 12:21:40PM +0200, Étienne Mollier wrote:
> > I can confirm excluding third_party/cpuid.h does the job.
> 
> OK.  Please note just mentioning it in Files-Excluded is not
> sufficient.  I recreated the tarball and uploaded.  I also
> opened an issue upstream[1] according to this.

Thanks for the notice, that makes sense.  Lintian showed a big
red error about file excluded in source, I probably would have
pushed a bit further if it were not that late in the evening.
I just had a look to your commit to learn how this was done, I
see removing the file from the upstream branch does the job.
Thanks also for the forward upstream!

> > The diff below shows what I pushed to salsa yesterday; it is a
> > bit different from my statement in my email, as I filter out
> > x86_64 for setting POPCNT_CAPABILITY=0 instead of listing
> > architectures that do not have this available
> 
> That's perfectly sensible - no idea why I made it that complicated.

No problem, I believe working mainly with patches tends to skew
a bit our own way of writing code: the smaller the diff, the
better, except it may not be the simpler approach.  Anyway, glad
to have been of help.

Kind Regards,
-- 
Étienne Mollier <etienne.mollier@mailoo.org>
Old rsa/3072: 5ab1 4edf 63bb ccff 8b54  2fa9 59da 56fe fff3 882d
New rsa/4096: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/2, please excuse my verbosity.

Attachment: signature.asc
Description: PGP signature


Reply to: