Re: Sponsored upload for shasta
Hi Shayan,
sorry for beeing slower than usual with sponsering. I slowly recover to
"normal operation" after DebConf. ;-)
On Sat, Aug 29, 2020 at 05:27:10PM +0100, Shayan Doust wrote:
> I believe Shasta[1] is ready for a sponsored upload. Please let me know
> if anything needs altering.
I was stumbling upon "Files: src/MurmurHash2*" since we have
libmurmurhash packaged. But it seems this version 2 is a new code base
and may be we should split this out in another package **later** (so no
need to change anything in shasta right now IMHO. Just mentioning it
since I expect more packages featuring code copies. At least source
package python-murmurhash has files with the same name.
I've found another copyright string in
docs/PythonApi/conf.py
# copyright = '2018, paoloczi'
# author = 'paoloczi'
My guess is ftpmaster will stumble upon it. I admit I personally have
no idea how this string relates to that file of "code" - may be just a
boilerplate? But I think this file should be mentioned to not risk a
reject.
Besides this the package does not build in my pbuilder environment:
dh_install
dh_install: warning: Cannot find (any matches for) "debian/tmp/build/*/*/*/shasta-install/bin/shastaDynamic" (tried in ., debian/tmp)
dh_install: warning: shasta missing files: debian/tmp/build/*/*/*/shasta-install/bin/shastaDynamic
dh_install: warning: Cannot find (any matches for) "debian/tmp/build/*/*/*/shasta-install/bin/shasta.so" (tried in ., debian/tmp)
dh_install: warning: python3-shasta missing files: debian/tmp/build/*/*/*/shasta-install/bin/shasta.so
dh_install: error: missing files, aborting
I've checked where those files ended up inside the pbuilder chrooT:
/build/shasta-0.5.1# find . -name shastaDynamic
./obj-x86_64-linux-gnu/dynamicExecutable/shastaDynamic
./debian/tmp/build/shasta-0.5.1/obj-x86_64-linux-gnu/shasta-install/bin/shastaDynamic
/build/shasta-0.5.1# find . -name "*.so*"
./docs/PythonApi/shasta.so
./obj-x86_64-linux-gnu/dynamicLibrary/shasta.so
./debian/tmp/build/shasta-0.5.1/obj-x86_64-linux-gnu/shasta-install/docs/PythonApi/shasta.so
./debian/tmp/build/shasta-0.5.1/obj-x86_64-linux-gnu/shasta-install/bin/shasta.so
Shayan, may be this rings a bell in you since you dealed way more
intensely with this package. If not, feel free to ask me for doing
deeper investigations.
Kind regards
Andreas.
> [1]: https://salsa.debian.org/med-team/shasta
--
http://fam-tille.de
Reply to: