[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: advice for gneiss package (more specifically, its unit tests)





On Thu, 9 Jul 2020, 03:15 Shayan Doust, <hello@shayandoust.me> wrote:
Hello Nilesh,

> If it's a test-only dependency, IMO you can simply skip that particular
> test for now.
> And enable testing it when bokeh is packaged and accepted into the
archive.

> Yeah, I'd anticipate probably not needed.
> All the upstream tests but one pass, as you reported above - this sounds
> more convincing that it's very likely not needed.
>
> FWIW: Bokeh is a data visualization module, and maybe that's used in
> tests to visualize and confirm the results of gneiss and nothing more.

I'm skeptic about this being a test-only module. Imports to bokeh are
done more-so within the gneiss files and not the test files itself, for
instance in the regression plot file[1]

Ah, then this is being used for the data visualization part here, and is probably not a test-only dependency.
I suppose the _core_ functionality (analysis) will remain unaffected, but the visualisation part will be unusable.
Can you try to use this module - maybe try reading docs and see how broken/not-brokem it looks?
If there's no visualization, maybe this isn't fit to go to the archive yet.


> As an additional work - you can enquire about the status of bokeh
> packaging by replying to the bug, CC'ing Diane (who's doing the original
> work)

I will perhaps ping the bug report and see if there is anything,

I suppose that makes sense. Maybe we'll have to wait till Bokeh gets uploaded, replying might help speed up the process.

although I couldn't find anything "bokeh" on Salsa (unless packaging
efforts are being done elsewhere).

Here[2]

Kind regards,
Nilesh


[2]: https://github.com/detrout/python-bokeh

Reply to: