Re: [Help Needed] pyranges
Hi Nilesh,
On Sun, Jun 21, 2020 at 02:14:25PM +0530, Nilesh Patra wrote:
> Hi,
> pyranges finally builds now with passing tests - however there are a few
> issues as lintian reports.
>
> Processing triggers for libc-bin (2.30-8) ...
> E: pyranges source: source-is-missing docs/libs/gitbook-2.6.7/js/app.min.js
> E: pyranges source: source-is-missing docs/libs/gitbook-2.6.7/js/lunr.js
> line length is 14839 characters (>512)
Argh, that's a nuisance. I had these gitbook JS in
https://salsa.debian.org/r-pkg-team/r-cran-bookdown
... luckily including non-compressed JS.
> E: pyranges source: source-is-missing docs/libs/jquery-2.2.3/jquery.min.js
That's usually done by Files-Excluded + Depends: libjs-jquery + dh_link
> E: python3-pyranges: unknown-file-in-python-module-directory
> usr/lib/python3/dist-packages/hi
?
No idea about this - my laptop is working hard to build the test suite
so I do not yet have any chance to inspect the result.
> I know what this is about - this is because this ships minified javascript
> - which is forbidden in debian.
> There are several such JS files vendored in the documentation.
>
> However - the documentation is vendored in two formats:
> 1. html files with corresponding JS
> 2. The exact same documentation is also vendored in .Rmd format - I've
> compared it and it is indeed, same.
>
> Now, coming to the problem:There are two ways to fix the errors:
>
> 1. The most ideal way will be to remove all the javascript files and
> symlink against system files.
> However, as you can see: there's a file named "app.min.js" : this is a
> pretty generic name with no obvious source.
As I said its somewhere hidden inside the source of another package.
> Hence, I need to ask upstream to provide that file and minify it during
> build - not sure how many
> weeks(or months this will take)
>
> 2. Simply remove the html + vendored JS. The documentation is anyway
> vendored in .Rmd files, and
> by doing this I'm not depriving the users from the documentation - I'm
> just reducing the functionality
> a little by removing html files.
Yes. That's *way* more simple and straightforward. I doubt that any
user will read it in the Debian package. Just add a README.Debian
where to find the docs online and that's it.
> I admit that I'm honestly tempted to go with this option since this saves
> me from a lot of un-necessary work
> as well as waiting for upstream to give me the source of "app.min.js" -
> the docs are delivered anyway, albeit in
> different format - hence I do not see any side-effects of doing this.
Just go for it and save your valuable time.
> I need opinions and "ACKs" before I do anything. Please let me know what
> seems good to you.
Thanks a lot for your work on this
Andreas.
--
http://fam-tille.de
Reply to: