[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Pushing verbose mode


I took the freedom to just upload as is since chances are good that
Helmut does just to do "simply nothing" which is better than forcing him
to test and send a response.  Hope this strategy is successfull.

Étienne, thanks a lot for your work


On Wed, May 13, 2020 at 11:12:09PM +0200, Étienne Mollier wrote:
> Control: tags -1 patch
> Hi Helmut,
> Helmut Grohne, on 2020-05-13 14:14:19 +0200:
> > I fear you only implemented a partial solution (based on my
> > recommendation here). In my tests, failures still go unchecked. I think
> > at least one issue is the linker rule in src/c_make.gen starting with
> > line 359. You added "set -e" there. The command snippet has an outer if
> > branch to select the linker (C vs C++) and an inner branch that removes
> > the linked file on failure. Unfortunately, the failure path does not
> > propagate the failure, because it is already captured in the if. Thus
> > swallowing errors. I didn't see this when writing my bug report either.
> Yes, I must admit the symbols soup does not make this structure
> very apparent.  I modified the patch and tried to adapt the
> logic here without drifting too much out of the original file,
> yet it required reorganizing the commands a bit.  After some
> testing, error codes from the linking stage should be returned
> properly; if otherwise then I would tend to think the linker
> didn't return an error code in the first place.
> > Beyond this, I strongly recommend implementing verbose build logs. The
> > issue would have been much easier to spot with verbose build logs. Build
> > logs have been a release goal[1]. Building verbosely is also recommended
> > by the Debian policy section 4.9. Unfortunately, the build system at
> > hand doesn't make this possible without patching.
> Agreed.  I did a thorough rereading of the Makefiles, and got
> rid of the "@" prefix of most commands.  Build logs are now
> showing what is happening, so even if changes here over are not
> sufficient to close the bug yet, at least the verbosity level
> should now allow to see more clearly what is happening.
> I made the patch available on Salsa.  If maybe you wish to have
> a try and review changes, before further package upload, you can
> grab it here:
> 	https://salsa.debian.org/med-team/tigr-glimmer/-/blob/master/debian/patches/make-errs.patch
> I hope this one will help.
> > Helmut
> > 
> > [1] https://wiki.debian.org/ReleaseGoals/VerboseBuildLogs
> Kind Regards,
> -- 
> Étienne Mollier <etienne.mollier@mailoo.org>
> Fingerprint:  5ab1 4edf 63bb ccff 8b54  2fa9 59da 56fe fff3 882d
> Help find cures against the Covid-19 !  Give CPU cycles:
>   * Rosetta@home: https://boinc.bakerlab.org/rosetta/
>   * Folding@home: https://foldingathome.org/


Reply to: