[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFS tigr-glimmer: reinforced `make` error checking

Control: tags -1 patch

Good day,

I had a look at the package tigr-glimmer and wrote a patch to
reinforce the Makefile infrastructure where it seemed needed.
The issue can be reproduced by specifying an invalid C++
compiler and attempt a build:

	$ CXX=invalid-cpp make -C src

While the build errors with several messages about invalid-cpp
command not found, the `make` execution happily returns 0 to the
shell.  With the patch, it becomes error code 2 as expected.

The report mentions errors in the context of crossbuilding, but
I don't believe I have managed to trigger issues that way.
Of course if the following is supposed to be fatal, then there
is always a possibility that my patch is incomplete:

	/usr/lib/gcc-cross/riscv64-linux-gnu/9/../../../../riscv64-linux-gnu/bin/ld: skipping incompatible /usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1

(Note that I just did a quick test, my build environment might
 have been the cleanest.)

The patch is available on Salsa and should be ready for upload:


(For once I have not forgotten about the git tag built added by
 the command routine-update.  :)

I hope this helps,
Kind Regards,
Étienne Mollier <etienne.mollier@mailoo.org>
Fingerprint:  5ab1 4edf 63bb ccff 8b54  2fa9 59da 56fe fff3 882d
Help find cures against the Covid-19 !  Give CPU cycles:
  * Rosetta@home: https://boinc.bakerlab.org/rosetta/
  * Folding@home: https://foldingathome.org/

Attachment: signature.asc
Description: PGP signature

Reply to: