[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#950311: FastQC users attention: Please comment on the remaining failures! (Was: Bug#950311: fastqc: autopkgtest regression: debhelper bump moved files to different location)



Hi Tony,

On Mon, Apr 06, 2020 at 04:22:03PM -0700, tony mancill wrote:
> > This sounds all pretty convincing.  Feel free to do a team upload
> > implementing your suggestion.
> 
> I went ahead and implemented this as a comparison of the summary output
> with the "known good" output and pushed as a merge-request to Salsa [1].
> I haven't done much with autopkgtests yet and hoped that someone could
> take a look at the change I made to exit non-zero if the comparisons
> fail.  This seems like what we want to happen, but I wasn't sure.

I just uploaded with your test unchanged.
 
> I tested by running autopkgtest with a good build and a "bad" build (by
> altering one of the expected summary output files) and I think it works
> as expected.
> 
> If it looks okay, I can take care of the team upload.

I just uploaded after running routine-upload.  Later I noticed that the
existing test did not served as user example as we try to approach this
for all tests in the Debian Med team.  Since you said you have not yet
done much with autopkgtests:  We install the run-unit-test script and
all data into /usr/share/doc/PACKAGE/examples and explain the user how
to run that very test on the local machine in some README.test.  I did
so now in Git (waiting for more good reasons for another upload).

Thanks a lot for your helpful contribution

        Andreas.

-- 
http://fam-tille.de


Reply to: