Re: Merge Request regarding package scrm
Hi Samyak,
On Fri, Mar 13, 2020 at 02:15:43AM +0530, Samyak Jain wrote:
> For the same, a merge request has been opened which can be found at [1];
> The MR includes various commits such as updating to the latest version,
> adding salsa-ci.yml and autopkgtest enabling.
sorry for the delay. I had some very busy days. Besides the commits I
did quickly I'd like to comment a bit on these. At first I have reset
the target distribution from "unstable" to "UNRELEASED". Usually the
sponsor of the package sets it to "unstable" before the real upload is
done. After I did so I was calling
routine-update --force [2]
which automatically fixes several things (and would even automatically
update to the latest upstream version)
> It would be great if someone can review it and help me with the issue :D
Regarding a detailed review:
1. You added debhelper input files for an example package but
you missed to add it to d/control
(see commit 586d0cb3c69ad0ddfbe3ee2568c78029d869da77)
2. I also fixed the installation of the multibinary package
(see b2278fb93510ab54182cdd07fc0d09b2bce6646a)
3. Since at build time some tests are run the results of these
remain inside the source tree. Before the files will be installed
into the binary package that needs to be cleaned up.
(see dec6b7ecf309b638a98d6cc544db7776d4e5b03e)
4. The automatically called tool dh_compress is compressing
all docs where compression makes sense. Since run-unit-test
is longer than usual it would be compressed without
commit f1755081b6d0ddb25f6320cfc41356a5e2fa0f33
5. run-unit-test does not really work. Its calling make
but there is no makefile. I added some debug code to
find it out. Please start investigating here. May be
you simply add the shell commands to run the tests or
you ship a simple Makefile
> Looking forward to a positive response :)
Hope these explanations will be helpful
Andreas.
[2] https://salsa.debian.org/science-team/routine-update/-/blob/master/routine-update
> [1] https://salsa.debian.org/med-team/scrm/-/merge_requests/1
--
http://fam-tille.de
Reply to: