[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] lefse migration to python 3

Hi Shayan,

On Fri, Sep 06, 2019 at 08:41:21PM +0100, Shayan Doust wrote:
> > This leads to a way shorter patch than yours mostly single lines
> > and not replacements of whole functions.  How did you created your
> > patch?
> Oh I see. I did:
> 2to3 --nobackups --write *.py recursively in the main working directory
> and lefsebiom folder

> autopep8 -i *.py to ensure pep8 compliancy

I think we should leave this for upstream.  It will lead to patches that
are larger than needed for the Python3 migration. (But you just confirmed
this in your other mail.)

> git diff > debian/patches/2to3.patch
> git stash
> and allowed dh_python3 to replace the shebang instead of using sed.

That's perfectly fine.
> > BTW, I also add DEP3 headers with the fields
> >     Description
> >     Author
> >     Last-Updated
> >     Bug-Debian
> Thanks. I was leaving that at the end just so I wasn't sure if the patch
> needed redoing.

Fair enough.
Kind regards



Reply to: