[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] lefse migration to python 3



Hi Shayan,

On Fri, Sep 06, 2019 at 04:57:30PM +0100, Shayan Doust wrote:
> I think I have done everything to make this package work with python 3
> and deprecate usage of python 2. First time touching python so I would
> rather have someone quickly check this before I append a changelog and

Your 2to3 patch looks pretty long.  What I'm doing for the conversion
is the following:

   find . -name "*.py" -exec 2to3 -w \{\} \;
   find . -name "*.py" -exec sed -i '1s:#!/usr/bin/env python:#!/usr/bin/python3:' \{\} \; 
   git diff > debian/patches/2to3.patch
   git stash
   find . -name "*.bak" -delete

This leads to a way shorter patch than yours mostly single lines
and not replacements of whole functions.  How did you created your
patch?

BTW, I also add DEP3 headers with the fields
    Description
    Author
    Last-Updated
    Bug-Debian

Kind regards

      Andreas.

-- 
http://fam-tille.de


Reply to: