[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Test file

Hi Saira,

On Tue, Jun 25, 2019 at 04:49:53PM +0100, Saira Hussain wrote:
> > 
> > Definitely not.  You should not even run that script *inside*
> > run-unit-tests.  Your script to fetch that data file has the only
> > purpose to *document* how that data file was obtained.  It is now
> > provided inside the debian/ dir and there is no point in re-getting it
> > over and over.  The run-unit-tests script should just refer to this date
> > file inside the file system.
> > 
> Now I understand! I mis-interpreted the verb document :) I thought you mean
> the action of running this script is defined as the documentation! Thanks
> for clearing this up, now it makes sense again!

> (Meanwhile I was hacking away and added python3-pip in the debian/control
> but don't worry, I am going to revert those changes!

Just for the educational purpose I need to clarify one thing:  python3-pip
would have been the wrong dependency anyway.  Using pip you download *not*
*yet* packaged Python modules.  However, BioPython is packaged and thus
(if at all) the correct dependency would have been python3-biopython.

Kind regards



Reply to: