[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: What ffindex do we want to package



Heya, I have replied, at least I had typed it :o/

So, yes, I had chosen that version of ffsort_index to get hhsuite to compile. I have no idea if there are other reverse dependencies on ffindex, my priority is on hhsuite.

Cheers,

Steffen

On 04.01.19 18:17, Michael Crusoe wrote:
I think 0.9.9.7+sog+git20160415.14274c9-1 is the source of the recent FTBFS of hhsuite: https://bugs.debian.org/917495 as our packaged version is missing the "ffsort_index" function.

The hh-suite github repo contains a submodule pointing at their fork of ffindex at ~ 2017-06-01: https://github.com/soedinglab/hh-suite/tree/v3.0-beta.3/libhttps://github.com/soedinglab/ffindex_soedinglab/tree/360e4176ece531be34a94298c808349916d016ac

I suggest that we package it as part of hhsuite until another package needs it.

hhsuite does provide  "*-Source*" packages that include ffindex, so we wouldn't need a multi-source build.



În joi, 20 dec. 2018 la 11:59, Andreas Tille <andreas@an3as.eu <mailto:andreas@an3as.eu>> a scris:

    Ping?
    Steffen, if you did not had a specific reason I assume it was by
    mistake and will replace the Segfaulting code by the original one.
    If I do not hear from you I assume you will agree.
    Kind regards, Andreas.

    On Wed, Dec 19, 2018 at 09:53:38AM +0100, Andreas Tille wrote:
    > Hi,
    >
    > after reading
    https://github.com/soedinglab/ffindex_soedinglab/issues/4
    > I came to the conclusion that we somehow picked the wrong fork of
    > ffindex.  For me it seems very probable that if we pick the old
    codebase
    > bug #907624 which was introduced when choosing this will vanish
    if we
    > revert to the previously packaged code base.  I have a local commit
    > which is doing this:
    >
    >
    > diff --git a/debian/changelog b/debian/changelog
    > index 6a26115..c409f4f 100644
    > --- a/debian/changelog
    > +++ b/debian/changelog
    > @@ -1,3 +1,12 @@
    > +ffindex (0.9.9.7+sog+git20160415.14274c9-1) UNRELEASED;
    urgency=medium
    > +
    > +  * The previous location on Github was an improperly choosen fork
    > +    (see https://github.com/soedinglab/ffindex_soedinglab/issues/4)
    > +    Here the version is now named "0.9.9.7+sog" (Saved On Github)
    > +    to make it alphabethically later than the previous one.
    > +
    > + -- Andreas Tille <tille@debian.org <mailto:tille@debian.org>>
    Wed, 19 Dec 2018 09:16:09 +0100
    > +
    >  ffindex (0.9.9.7+soedinglab+git20180802.74550c8-1) unstable;
    urgency=medium
    >
    >    * Fix watch file (version should actually be
    +git20171201.74550c8 but
    > diff --git a/debian/watch b/debian/watch
    > index 91b4f38..b47f123 100644
    > --- a/debian/watch
    > +++ b/debian/watch
    > @@ -1,4 +1,4 @@
    >  version=4
    >
    > -opts="mode=git,pretty=0.9.9.7+soedinglab+git%cd.%h" \
    > - https://github.com/soedinglab/ffindex_soedinglab.git HEAD
    > +opts="mode=git,pretty=0.9.9.7+sog+git%cd.%h" \
    > + https://github.com/ahcm/ffindex.git HEAD
    >
    >
    >
    > Upstream at github.com/ahcm/ffindex
    <http://github.com/ahcm/ffindex> was extremely quick to tag a
    > release and so it is at least active.
    >
    > Steffen, was your pick intentional or did you just stumbled by
    chance
    > over the other fork?  Are you OK with reverting to the old code?
    >
    > Kind regards
    >
    >       Andreas.
    >
    > PS: I reported the segfault issue to the according fork anyway
    > https://github.com/soedinglab/ffindex_soedinglab/issues/7
    >
    >
    > --
    > http://fam-tille.de
    >
    >

-- http://fam-tille.de



--
Michael R. Crusoe
Co-founder & Lead, Common Workflow Language project <http://www.commonwl.org/>
Direktorius, VšĮ "Darbo eigos", Vilnius, Lithuania
https://orcid.org/0000-0002-2961-9670 <https://impactstory.org/u/0000-0002-2961-9670>
mrc@commonwl.org <mailto:mrc@commonwl.org>
+1 480 627 9108 / +370 653 11125


Reply to: