[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New package bali-phy

Hi Benjamin,

thanks for packaging bali-phy which looks quite good.  You even added
autopkgtest which is excellent work.

On Thu, Mar 08, 2018 at 05:44:59PM -0500, Benjamin Redelings wrote:
>     I've created a new project on salsa for the software 'bali-phy'.  It
> builds for me with gbp without any lintian warnings, and the installed
> packages seem to work.  Comments?

I've added pristine-tar as per policy[1], removed the redundant
debian/gbp.conf and changed the formatting of the d/control file
using `cme fix dpkg-control` to have some consistent formatting
between other Debian Med packages.

I also added a spelling fix as quilt patch.  I'm not always that picky
but since you are upstream you most probably want to fix this in your
code as well.  Hint:  If you are runnin lintian with -I option you get
also those issues.

Something you might like to consider is the location of the examples
which is currently in /usr/share/bali-phy/examples.  In Debian users are
used to check /usr/share/doc/PACKAGENAME/examples (no idea how many
users are *really* trained to look there - but at least this is the
recommended location).  Moreover if we have some autopkgtest which is
providing some kind of example usage I tend to put this script as well
in this location and add a README.test that enables users on their local
machine to reproduce these tests as examples.

So far for the cosmetical things.  There is one issue left which I would
like to discuss:  In external/ dir there are code copies of Debian
packaged libraries.  I noticed that you have added all those libraries
as Build-Depends and thus I assume the build is clean and is using the
Debian packaged versions.  My way to deal with this kind of third party
software in upstream sources is to remove them completely from the
tarball.  This has two advantages:
   1. I can be *really* sure that the Debian packaged version is used
   2. It saves me work from mentioning the stuff in d/copyright (which
      can be quite complex some times)

If you agree with this approach I can do this for you as a simple
example since with Files-Excluded in d/copyright this is pretty easy
to do.  In other words:  The package is OK in principle and I could
upload as is.  So if you prefer an untouched upstream tarball that
should be fine.  But I personally would strip third party source and
if you want me to do this for you I can do before uploading.

Thanks again for your work on this


[1] https://debian-med.alioth.debian.org/docs/policy.html#git-tips


Reply to: