[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: libzstd 1.1.2 contains embedded zlib fork



Hi Kevin,

thanks for your email.

>> I was looking to update libzstd to the current upstream version 1.1.2.
>> Besides some minor changes to the patches I had to make, I also noticed that
>> it now includes an embedded copy of some zlib code, which -- according to the
>> inline comments -- was adapted to be ready to compile with the zlibwrapper.
>> It wasn’t clear to me whether this was really necessary; when these files are
>> removed from the affected Makefile (and some minor adjustments are made) the
>> build still finishes fine.
> 
> That's been there since 1.1 I think, and is AFAICT example code for an
> alternative, non-packaged API that mimics the zlib API. It could be packaged
> under libzstd-dev:usr/share/doc/libzstd-dev/examples or something, like I've
> seen with a few development packages. Otherwise, I think nuking the sources or
> just removing them from the makefile is fine. Though from memory, anything
> compiled from these is not installed, so no action is probably also OK.

OK. I've checked that the new packages contain (at least) the same files as the 1.1.1 version, which is the case. So this indeed doesn’t touch the installed contents and I also agree that there shouldn’t be a problem.

[…]
> What does the DFSG say about sources that are
> not compiled? They're in d/copyright anyway, IIRC FTPMASTER bounced me last
> update for this exact issue, and I added them.

There are some new sources in zlibWrapper/ under zlib license by M. Adler. They are actually new in 1.1.2 and also compiled in the Makefile — thats why I was asking about them as I disabled them. To be on the safe side license-wise have added them to d/copyright as well, so I guess we should be fine.
Preparing an upload as we speak.

Cheers
Sascha

Attachment: signature.asc
Description: Message signed with OpenPGP


Reply to: