Re: [Outreachy] pymol

Hi Andreas,

I've fixed pymol.desktop.

There might be some errors with test dependencies, and some tests use pymol's fetch command (which loads pdb files not included to upstream), so I don't sure if they pass on Debian CI server. On schroot they all pass.

For now I'll finish apbs.

2016-08-17 11:20 GMT+03:00 merlettaia <merlettaia@gmail.com>:

Hi Andreas,

2016-08-17 10:57 GMT+03:00 Andreas Tille <andreas@an3as.eu>:
Hi Tanya,

On Tue, Aug 16, 2016 at 08:01:46PM +0300, merlettaia wrote:
> Could you please take a look at pymol?

I did now. I fixed some minor lintian issues (DEP3, override for
spelling). I also added some Breaks and a versioned dependency which is
important for upgrades when splitting a package. Please have a look at
the commits to debian/control which might be an interesting lesson for
other packages.

Thanks! I'll take a look.

> I made almost everything possible, except solving this warnings (but I can
> fix them too):
>
> I: pymol: desktop-entry-lacks-keywords-entry
> usr/share/applications/pymol.desktop

Please just let me know if you want to fix this.

I want to fix this.

> W: pymol: command-in-menu-file-and-desktop-file pymol
> usr/share/menu/pymol:7

Fixed by removal of menu file.

Thanks again for your tough work. I'll upload once I hear from you
about the desktop file. I'd also upload if you confirm: "Uhhmmm, no
idea what keyword would be appropriate."

Kind regards

Andreas.

--
http://fam-tille.de

--
Best wishes,
Tanya.

Best wishes,

Tanya.