[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Sponsoring request: libgtextutils; - next package I'll work on: libbpp-core



Hi,

there is another UNRELEASED changelog entry from Fabian Klötzl who has not
created a quit patch but directly changed the source:

$ git diff e9b891ca27a9ce298ae700cc26f631f1ca69c134^ e9b891ca27a9ce298ae700cc26f631f1ca69c134
diff --git a/src/gtextutils/text_line_reader.cpp b/src/gtextutils/text_line_reader.cpp
index fede933..28299e5 100644
--- a/src/gtextutils/text_line_reader.cpp
+++ b/src/gtextutils/text_line_reader.cpp
@@ -44,6 +44,6 @@ bool TextLineReader::next_line()
        if (input_stream.eof())
                return false;
 
-       return input_stream ;
+       return static_cast<bool>(input_stream) ;
 }


Gert's quilt patch is now changing this changed source which fails to build.

Fabian, in future could you please:

   1. Use quilt for patches
   2. Make some noise about your fix to prevent others doing
      the same work twice (if you did some noise but nobody
      was hearing - please make noise again and sorry if we
      did not respond).

While I could easily merge things I wonder what might be "the better
way to fix the issue"?

Kind regards

      Andreas.

On Wed, Jun 29, 2016 at 04:46:58PM +0200, Gert Wollny wrote:
> Hello all, 
> 
> I've prepared a new upload for libgtextutils [1]: 
> 
> Changelog 
> 
>   * Team upload.
>   * d/p/gcc-6.patch: Fix compilation with g++-6, Closes: #811646
>   * d/ibgtextutils0v5.lintian-override: add override for differently 
>     names -dev symlink
>   * cme fix dpkg-control
> 
> Many thanks, 
> Gert 
> 
> [1] git://git.debian.org/debian-med/libgtextutils
> 
> 

-- 
http://fam-tille.de


Reply to: